search

buildpacks / samples

Samples for Cloud Native Buildpacks
Apache License 2.0
194 stars 146 forks source link

Create sample apps with dockerfiles, hooks, etc #112

Closed aemengo closed 1 year ago

aemengo commented 2 years ago

In light of https://github.com/buildpacks/rfcs/pull/173, sample applications should be created with these new buildpack constructs: App Specified Dockerfile, Hook TOML, etc.

cmoulliard commented 2 years ago

Is the following builder structure correct ?

Screenshot 2021-10-08 at 17 15 56

@sclevine @natalieparellano @aemengo

natalieparellano commented 2 years ago

I think ext.toml should be extension.toml. I don't think build.ext.toml and launch.ext.toml are included in the RFC (they were just talked about).

natalieparellano commented 2 years ago

Please see https://github.com/buildpacks/lifecycle/issues/709#issuecomment-938746662 for an initial take on this issue.

cmoulliard commented 2 years ago

(they were just talked about).

I saw them from a comment of Javier Romero. will remove them and add also run.Dockerfile and build.Dockerfile

cmoulliard commented 2 years ago

Structure updated

Screenshot 2021-10-08 at 18 24 34