search

buildpacks / samples

Samples for Cloud Native Buildpacks
Apache License 2.0
194 stars 145 forks source link

Simplify condition to deploy on main #148

Closed AidanDelaney closed 1 year ago

AidanDelaney commented 1 year ago

Use the syntax from the Github Actions documentation

https://docs.github.com/en/actions/learn-github-actions/expressions

natalieparellano commented 1 year ago

Do we know why CircleCI is failing with ERROR: failed to build: failed to fetch builder image 'index.docker.io/cnbs/sample-builder:jammy': image 'index.docker.io/cnbs/sample-builder:jammy' does not exist on the daemon: not found?

AidanDelaney commented 1 year ago

We have not sucessfully published a :jammy image yet, because the GH workflow keeps skipping the deploy step. Hence, in this PR, we're simplifying the condition.

On Mon, 3 Apr 2023, 16:37 Natalie Arellano, @.***> wrote:

Do we know why CircleCI is failing with ERROR: failed to build: failed to fetch builder image 'index.docker.io/cnbs/sample-builder:jammy': image ' index.docker.io/cnbs/sample-builder:jammy' does not exist on the daemon: not found?

— Reply to this email directly, view it on GitHub https://github.com/buildpacks/samples/pull/148#issuecomment-1494550232, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADHKU55JOYG2GYYD7LRAFTW7LVDJANCNFSM6AAAAAAWOIBVB4 . You are receiving this because you authored the thread.Message ID: @.***>