buildpacks / samples

Samples for Cloud Native Buildpacks
Apache License 2.0
195 stars 147 forks source link

.NET Framework Samples #88

Closed ameyer-pivotal closed 4 years ago

ameyer-pivotal commented 4 years ago

Adds:

jromero commented 4 years ago

100+ files for a sample app? Is there anyway to minimize the number of files?

ameyer-pivotal commented 4 years ago

100+ files for a sample app? Is there anyway to minimize the number of files?

@jromero I suppose it is quite large. We were essentially trying to use a published sample that MS uses (based on this: https://github.com/microsoft/dotnet-framework-docker/tree/master/samples/aspnetapp) to show something that's more like a "real" app. That said, I agree this is large and will investigate alternatives

ameyer-pivotal commented 4 years ago

@jromero The sample app should be much simpler now (thanks @micahyoung!)

ameyer-pivotal commented 4 years ago

@jromero Hold off on merging this, as I want to put some logos back into this sample app

ameyer-pivotal commented 4 years ago

@jromero Hold off on merging this, as I want to put some logos back into this sample app

@jromero OK, all good now