search

buildpacks / spec

Specification for Cloud Native Buildpacks
https://buildpacks.io
Apache License 2.0
250 stars 69 forks source link

Fix: platform vars #367

Closed natalieparellano closed 11 months ago

natalieparellano commented 12 months ago

Related discussion: https://github.com/buildpacks/spec/issues/330#issuecomment-1634336710

hone commented 11 months ago

@natalieparellano so does that mean if a buildpack modifies an env var, does a subsequent buildpack always get what the user provided?

natalieparellano commented 11 months ago

@hone I went back to the code to confirm my understanding, and it's even more subtle than what I originally wrote. You can see it here: https://github.com/buildpacks/lifecycle/blob/f8b3419877ceab27f46af0621ec6d9d80650df44/env/env.go#L84-L91

As far as I can tell, this is how it has always worked. So we are just updating the language in the spec to reflect what has been happening all along.