search

buildpacks / tekton-integration

Buildpacks + Tekton
22 stars 3 forks source link

Use the new Heroku builder images in the example builders lists #39

Open edmorley opened 10 months ago

edmorley commented 10 months ago

The heroku/buildpacks:* builders have been replaced by heroku/builder:* and the former are about to be deprecated.

See: https://github.com/heroku/cnb-builder-images/blob/main/README.md https://github.com/buildpacks/pack/pull/1924

edmorley commented 10 months ago

cc @jromero - I think you might be the best person to review given recent the git log (I'm not able to select you as a reviewer via the GitHub reviewers interface since that can only be accessed by users with maintainer access).

jjbustamante commented 5 months ago

Hi @edmorley

I know it is unrelated to your change, but could you update the .github/workflows/test.yaml with a new runner? from what I can see we are using a very old one and the tests are not running.

Test: .github#L1 The ubuntu-18.04 environment is deprecated, consider switching to ubuntu-20.04(ubuntu-latest), or ubuntu-22.04 instead. For more details see https://github.com/actions/virtual-environments/issues/6002

edmorley commented 5 months ago

@jjbustamante Done - could you re-approve the GHA workflow? :-)

jjbustamante commented 5 months ago

Oh man, this thing is too old.

It looks like they moved catlin to its repo now.

I tried to run the same commands we are running in the workflow.

➜  tektoncd git clone git@github.com:tektoncd/catlin.git
Cloning into 'catlin'...
warning: templates not found in /Users/juanbustamante/.git_templates
remote: Enumerating objects: 7687, done.
remote: Counting objects: 100% (909/909), done.
remote: Compressing objects: 100% (488/488), done.
remote: Total 7687 (delta 463), reused 755 (delta 386), pack-reused 6778
Receiving objects: 100% (7687/7687), 11.82 MiB | 6.86 MiB/s, done.
Resolving deltas: 100% (3200/3200), done.
Updating files: 100% (3443/3443), done.
➜  tektoncd cd catlin/cmd/catlin
➜  catlin git:(main) go get github.com/tektoncd/catlin/cmd/catlin
go: downloading go.uber.org/zap v1.27.0
...
edmorley commented 4 months ago

@jjbustamante I think we should just archive this repo at this point, personally :-)