buildspace / buildspace-projects

The home of our open-source projects.
https://buildspace.so/projects
Creative Commons Attribution Share Alike 4.0 International
3.01k stars 1.09k forks source link

✨ [Solana Core]: 2 - 🧬 Give your token an identity #1649

Closed skaunov closed 1 year ago

skaunov commented 1 year ago

What You Are Changing

createCreateMetadataAccountV2Instruction signature is out of date \ and the corresponding instruction "...was deprecated in a previous release and is now removed"

Anything else?

https://github.com/metaplex-foundation/js/compare/c171e1e31d9fe12852afb39e449123339848180e..main#diff-4f98443a13d4473c4716a0da4ec8ceaef3faecb67f794da8f3a210635ec08dfc On the one hand it's the best illustration of the take given precisely in this place of the section, on another the code won't work.

Maybe leave a note there that not yet documented stuff need attention and can mutate during stabilization. And make finding correction a part of the exercise?

P.s. Let me add an obbious working snippet without imports just so it would be near.

createCreateMetadataAccountV3Instruction(
      {
        metadata: metadataPDA,
        mint,
        mintAuthority: user.publicKey,
        payer: user.publicKey,
        updateAuthority: user.publicKey,
      },
      {createMetadataAccountArgsV3: {
        data: tokenMetadata, isMutable: true, collectionDetails: null
      }}
    )
github-actions[bot] commented 1 year ago

This issue is marked as stale because it has been open for 30 days with no activity.

github-actions[bot] commented 1 year ago

This issue was closed because it has been inactive for 14 days since being marked as stale.