buildstream-migration / bst-staging

GNU Lesser General Public License v2.1
0 stars 0 forks source link

Missing cache key in log messages (workspace open) #663

Open Cynical-Optimist opened 4 years ago

Cynical-Optimist commented 4 years ago

See original issue on GitLab In GitLab by [Gitlab user @Qinusty] on Sep 20, 2018, 10:57

Summary

During bst workspace open, various messages do not contain the associated elements cache key.

Steps to reproduce

Open a workspace, observe output.

What is the current bug behavior?

Messages are produced without any cache key

What is the expected correct behavior?

All messages associated with the operation triggered for the element should contain its cache key.

Relevant logs and/or screenshots

[--:--:--][651aa7ef][ main:5G.bst                        ] START   Staging sources to /home/joshsmith/buildstream/doc/examples/CAS-interaction/wspdir
[--:--:--][        ][ main:5G.bst-0                      ] STATUS  Running host command

    /usr/bin/git show 72b5902157316e173de2eec5b3a2772283eec3c7:.gitmodules

[--:--:--][        ][ main:5G.bst-0                      ] START   Setting up workspace "/home/joshsmith/.cache/buildstream/build/workspace-5Gr52jkhma"
[00:00:00][        ][ main:5G.bst-0                      ] SUCCESS Setting up workspace "/home/joshsmith/.cache/buildstream/build/workspace-5Gr52jkhma"
[00:00:00][651aa7ef][ main:5G.bst                        ] SUCCESS Staging sources to /home/joshsmith/buildstream/doc/examples/CAS-interaction/wspdir
[--:--:--][][] INFO    Saved workspace configuration

Other relevant information


Cynical-Optimist commented 4 years ago

In GitLab by [Gitlab user @tristanvb] on Sep 20, 2018, 11:12

Yes this is a bug.

Some clarifications:

So the above clearly appears to be a bug.

Cynical-Optimist commented 4 years ago

In GitLab by [Gitlab user @Qinusty] on Sep 20, 2018, 14:45

This is due to the message being produced by a source (The workspaced element main:5G.bst-0) and message.task_id is unset.