Closed shahzebsiddiqui closed 4 years ago
That seems reasonable. I would not take s
for this, however, but just use --settings
since it corresponds to a settings.yml file. --site-config
is also reasonable.
I thought we removed buildtest config view? For buildtest config edit, it doesn't add much to allow the user to specify some default path to edit. If they need to specify the path, they can just open the file with their editor directly :)
I thought we removed buildtest config view? For buildtest config edit, it doesn't add much to allow the user to specify some default path to edit. If they need to specify the path, they can just open the file with their editor directly :)
No we didnt remove buildtest config view
same with edit
. The one that was removed was buildtest show --config
see https://github.com/HPC-buildtest/buildtest-framework/issues/215
I am not sure how relevant the view
and edit
option are going to be. Initially what i had in mind was having ability to edit and view site-configuration and test configuration file from buildtest. It could be useful for editing YAML files simply through command line if they are in some long cryptic path.
Ah ok. For the buildtest config edit
I think I mentioned this once before, but I really liked using it. I think we should keep it for the time being, it saves needing to remember and look up the file.
Thats good to know, i think its fine for buildtest config [edit|view]
to work for default configuration, if they have to specify an alternate configuration file which is scoped for this task then they might as well open file in editor.
Currently there is no support for user to specify a different site configuration, it must be stored in
$HOME/.buildtest/settings.yml
.Logically, it makes sense for
buildtest build
to have an option to specify path to site configuration they want to use instead of copying file everytime, this would make sense when a file sits in source control that user wants to make change instead of copying or moving file back-forth.The option can be
buildtest build -s
or long option--site
or--site-config
. I am fine with with either long name. This could be relatively easy to do, currently we don't have-s
so it could be a viable short option to use.This does mean that
buildtest config view
andbuildtest config edit
won't work with custom path to site config since they are looking at the default location.Let me know your thoughts @vsoch. I would use this feature once i put site configuration for Stampede in https://github.com/HPC-buildtest/buildtest-stampede2