builtbybel / ReadySunValley

Replacement for Microsoft PC Health Check app
https://www.builtbybel.com
MIT License
200 stars 21 forks source link

Embed localization files in the executable file #27

Closed Oleg-Chashko closed 2 years ago

Oleg-Chashko commented 2 years ago

Please embed the localization files in the executable.

Screen Shot 2021-07-13 at 15 48 46
Belim commented 2 years ago

this is a problem for me. the exe will grow the more localizations we have and i want to avoid that.

but you could outsource the localizations and make them optional for download. what do you think?

Oleg-Chashko commented 2 years ago

this is a problem for me. the exe will grow the more localizations we have and i want to avoid that.

but you could outsource the localizations and make them optional for download. what do you think?

  1. When starting the program, offer a list of languages, and if the user chooses, download it from the Internet and run the program with this localization.
    • What if there is no connection to the Internet?
    • Should we make the code more complicated?

It is easier to build it into an executable file. The size of your localization file is very small. Apply compression.

Belim commented 2 years ago

this is a problem for me. the exe will grow the more localizations we have and i want to avoid that. but you could outsource the localizations and make them optional for download. what do you think?

  1. When starting the program, offer a list of languages, and if the user chooses, download it from the Internet and run the program with this localization.
  • What if there is no connection to the Internet?

no win11 😁 the language file for ReadySunValley is not needed then either

  • Should we make the code more complicated?

i like it 😁 um...sometimes

It is easier to build it into an executable file. The size of your localization file is very small. Apply compression.

i would suggest to continue like this until we don't have some more localizations on board. if there should be more than 10, then we should think about something.

Oleg-Chashko commented 2 years ago

Closed the discussion, if necessary, you can reopen it.