builtbybel / ReadySunValley

Replacement for Microsoft PC Health Check app
https://www.builtbybel.com
MIT License
200 stars 21 forks source link

You need to provide credit. #3

Closed d3n4c3 closed 3 years ago

d3n4c3 commented 3 years ago

If you're going to basically copy my code line for line you should probably credit me in your repo and application. Considering you've been releasing it on software websites without mention of my authorship. I'd be okay with a link to the original github added in your program.

Belim commented 3 years ago

hmm https://github.com/builtbybel/moin-11#credits

d3n4c3 commented 3 years ago

That's hardly a credit. You're saying you based it off of it. You took the code line for line. You really should provide credit in your compiled application that you're distributing as well. It's just a good faith practice. In the future I hope you consider the worth of others a bit more when doing things like this. We could have collaborated together on the project instead of you copy pasting it to a new repo, making some minor changes, stamping your name on it, and distributing it to software publishers.

d3n4c3 commented 3 years ago

Also you've added a MIT license and your own copyright to my code without even mentioning me in the license information. I hope you really understand how truly bad that is.

Belim commented 3 years ago

:sleepy: https://github.com/builtbybel/moin-11/blob/main/LICENSE

d3n4c3 commented 3 years ago

You don't have to give me full credit but you can link to me at least. Thank you for understanding my point though.

Belim commented 3 years ago

actually i just wanted to push your code, because no one else on this earth would have seen it. i discovered it by chance when i wanted to deal with tpm, but found no way to access it in .net. i'm honest and can tell you that i spent 3 minutes on the code and 11 more on the gui during the work breaks and actually it was finished for me. the basic idea is not bad so i went on again.

I will also mention you in the program. You were the first to come up with the idea, you're right! although today I discovered a tool called whynotwin11, which does the same but it is just an autoit script and I don't like it at all. maybe we can do it better :grin: