search

builttoroam / device_calendar

A cross platform plugin for modifying calendars on the user's device
https://pub.dev/packages/device_calendar
BSD 3-Clause "New" or "Revised" License
260 stars 263 forks source link

Pull request related to [Issue 298 - Change of actual Recurrence Rule Class] #400

Closed GoldenSoju closed 2 years ago

GoldenSoju commented 2 years ago

Pull request related to Issue 298 - Change of actual Recurrence Rule Class

thomassth commented 2 years ago

It seems strange to have this many lines changed

Maybe try a fast forward merge?

GoldenSoju commented 2 years ago

@thomassth Sorry, but regarding fast forward merge, would you mind telling me how to do it the best way? This SO question doesn't really clarify it for me.

thomassth commented 2 years ago

There's no button on github that does that unfortunately

In my workflow (VSCode), I use Git Graph:

  1. add the main repo in a separate branch (there's a setting in Git graph, or you can do that with command line)
  2. pick "merge to current branch" at the latest commit
  3. uncheck the first option so that it will do a fastforward merge

Or you can just git push cause it does fastforward by default.

thomassth commented 2 years ago

Also, may I ask what was changed in your rrule? If it's ready, you should submit a PR over there too. Or else we may need to put it into our package somehow.

GoldenSoju commented 2 years ago

@thomassth

  1. Please check the new pull request 403.
  2. Most notable changes to Rrule were:

Please see also this change report.

thomassth commented 2 years ago

Closing this since we have #403 now.