search

builttoroam / device_calendar

A cross platform plugin for modifying calendars on the user's device
https://pub.dev/packages/device_calendar
BSD 3-Clause "New" or "Revised" License
260 stars 263 forks source link

iOs fix - allDay event does not span multiple days #413

Closed vasilich6107 closed 1 year ago

vasilich6107 commented 2 years ago

Fix for #220

vasilich6107 commented 2 years ago

Hi @bhl09 I'm fixing this line of your code https://github.com/builttoroam/device_calendar/blame/988f671f43516d4f6d7ec4969172b7f4b84fa833/ios/Classes/SwiftDeviceCalendarPlugin.swift#L680

Could you look at my PR

thomassth commented 2 years ago

Your fix looked a bit ... simple?

Does it set the multiple all-day events in iOS correctly?

And if that's the case, we need to update the demo app as well

vasilich6107 commented 2 years ago

Hi @thomassth In understand your concerns about the fix)

I will film a short video for you later today.

thomassth commented 2 years ago

A simple Y/N would do 😂

And we need to write a test for it too

vasilich6107 commented 2 years ago

Got you)

Yes it fixes the issue and creates multiday allday event.

I will add the tests and ping you.

thomassth commented 1 year ago

You need to rebase your PR before merging.

vasilich6107 commented 1 year ago

Ok, will do

OleksandraFedotova commented 1 year ago

That is not enough for the fix, you do not take into account the timezone set - in your fix - all FullDay events for multiple days and not - will have midnight time - I checked that on the test IOS device Check my PR - there is a correct fix for that - https://github.com/builttoroam/device_calendar/pull/450