search

builttoroam / device_calendar

A cross platform plugin for modifying calendars on the user's device
https://pub.dev/packages/device_calendar
BSD 3-Clause "New" or "Revised" License
260 stars 263 forks source link

[Dublicate Code] parseStringToAvailability called twice in Event.fromJson (Event Class - Dart) #418

Closed GoldenSoju closed 1 year ago

GoldenSoju commented 2 years ago

Dublicate code I found in the Event class:

availability = parseStringToAvailability(json['availability']);

-> this is being called twice in lines 140 and 149 (Event.fromJson)

https://github.com/builttoroam/device_calendar/blob/988f671f43516d4f6d7ec4969172b7f4b84fa833/lib/src/models/event.dart#L140

https://github.com/builttoroam/device_calendar/blob/988f671f43516d4f6d7ec4969172b7f4b84fa833/lib/src/models/event.dart#L149

If I can file a PR I will soon hopefully, otherwise, leaving this here to not forget it.

thomassth commented 1 year ago

According to @catcecilia, seems to be fixed.