search

builttoroam / device_calendar

A cross platform plugin for modifying calendars on the user's device
https://pub.dev/packages/device_calendar
BSD 3-Clause "New" or "Revised" License
260 stars 263 forks source link

Android recurring events, edit single instance #428

Open kryjomskiDev opened 2 years ago

dwenderf commented 2 years ago

Does anything further need to be done in order to have this reviewed/merged?

thomassth commented 2 years ago

Does anything further need to be done in order to have this reviewed/merged?

Sorry got a lot on my plate right now

It looks good, but I think we also need tests Or at least add this function into the demo app so we can test manually

I might have some free time next week, or if it works in demo I can approve it

dwenderf commented 2 years ago

Thanks for getting back to me Thomas! Agreed that testing is a good idea. We're currently testing in our app, and once we are sure everything is working right, we'll either add unit tests or add to the demo app. However I can say that we are finding some strange behavior with retrieving recurring events using the plugin. Very often, events that are recurring on my Google calendar are coming back with null for recurring event rule in the plugin. We'll continue to investigate to see if we can determine if there is any particular condition that causes this to occur.

thomassth commented 1 year ago

I have doubts on the interoperability. Changing a single event in Google calendar does not reflect on originalInstanceTime. Perhaps they are using other values?

thomassth commented 1 year ago

Also it seems that your branch does not allow maintainers to add commits.

If you can't modify access on the branch, I can send it to you.

dwenderf commented 1 year ago

Acutally it looks like PR #435 accomplishes this and more. It may be better to focus on that PR since it includes other enhacements as well.

thomassth commented 1 year ago

435 cramped too many thing into a single commit, and it is too difficult for anyone to check against.

Instead, I'd prefer using this, and if 435 has better approach on this specific issue, incorporate that here