search

builttoroam / device_calendar

A cross platform plugin for modifying calendars on the user's device
https://pub.dev/packages/device_calendar
BSD 3-Clause "New" or "Revised" License
259 stars 258 forks source link

[5.0] rrule compatability #446

Open thomassth opened 1 year ago

thomassth commented 1 year ago

Part of #445

After #403, quite a lot of recurrence rules have changed; hence

  1. point to rrule document where relevant
  2. provide some campatability to the old recurrenceRule, if it is not taking too much effort to maintain
  3. remove old references and documents to old methods
thomassth commented 1 year ago

WeekOfDay is not included in rrule it seems.

Right now the plan is to wait until it is solved on rrule side, but a 5.0 prerelease can go ahead.

GoldenSoju commented 1 year ago

@thomassth

WeekOfDay is not included in rrule it seems.

Right now the plan is to wait until it is solved on rrule side, but a 5.0 prerelease can go ahead.

If you refer to Implementing weekofmonth, please check if my reply is correct.

thomassth commented 1 year ago

I suspected it has something to do with BYDAY but I didn't have time to investigate it

As long as it's the same as how the Android/iOS did things, I am ok with that.

GoldenSoju commented 1 year ago

Yes, in the end they all use the same recurrence rule standard. For iOS documentation it would be EKRecurrenceDayOfWeek.