search

builttoroam / device_calendar

A cross platform plugin for modifying calendars on the user's device
https://pub.dev/packages/device_calendar
BSD 3-Clause "New" or "Revised" License
259 stars 258 forks source link

Remove faulty requestPermissions implementation in favor of working one #465

Closed tjarvstrand closed 1 year ago

tjarvstrand commented 1 year ago

Tthe current Swift-implentation of requestPermissions does not return if permissions have already been granted. Thus, if it is called more than once, subsequent attempts try to request permissions again, causing the call to fail with a 400-error (To create or update an all day event you must provide calendar ID, event with a title and event's start date).

There was already a second implementation of requestPermissions which wasn't used anywhere but correctly short-circuits if permissions have already been granted so I thought it would be better to use that.

EDIT: Actually, the errors seem to be caused by an error on my end. Regardless, this change seems reasonable to me, if less urgent :)

IVLIVS-III commented 1 year ago

Thanks for the PR, looks good on first glance. I will try and test it soon.

IVLIVS-III commented 1 year ago

Thank you for your contribution @tjarvstrand