search

builttoroam / device_calendar

A cross platform plugin for modifying calendars on the user's device
https://pub.dev/packages/device_calendar
BSD 3-Clause "New" or "Revised" License
267 stars 267 forks source link

Android build is failed for Kotlin 1.7.10 because of enum switch in 4.3.0 version #470

Closed KostyaRolique closed 1 year ago

KostyaRolique commented 1 year ago

Flutter build is failed with this error: /opt/homebrew/Caskroom/flutter/3.3.4/flutter/.pub-cache/hosted/pub.dartlang.org/device_calendar-4.3.0/android/src/main/kotlin/com/builttoroam/devicecalendar/CalendarDelegate.kt: (784, 9): ‘when’ expression must be exhaustive, add necessary ‘DAILY’, ‘HOURLY’, ‘MINUTELY’, ‘SECONDLY’ branches or ‘else’ branch instead

During the research I found out that android source code for release 4.3.0 isn't published (especially the file CalendarDelegate.kt): https://github.com/builttoroam/device_calendar/releases/tag/4.3.0 https://pub.dev/packages/device_calendar/versions

felix9ia commented 1 year ago

https://github.com/builttoroam/device_calendar/pull/457 Looks like we'll just have to wait for the 5.0 release the way to temporarily solve this problem, can downgrading koltlin solve it.

in android/build.gradle, to change kotlin version:

  ext.kotlin_version = '1.6.20'
thomassth commented 1 year ago

I think this deserves a .1 release

Will approve if someone can make it

(To "release" branch for prerelease)

hichaudh commented 1 year ago

any ideas on when the pub release of 4.3.1 might occur?

IVLIVS-III commented 1 year ago

@hichaudh the prerelease version 4.3.1-4217521123 is already released and available on pub.dev. The full release of 4.3.1 should occur about 1-2 weeks after the prerelease, i.e. within 4-11 days.

IVLIVS-III commented 1 year ago

@thomassth it has been almost 3 weeks since the pre-release and no issues have been reported. Can we release version 4.3.1?