search

builttoroam / device_calendar

A cross platform plugin for modifying calendars on the user's device
https://pub.dev/packages/device_calendar
BSD 3-Clause "New" or "Revised" License
259 stars 258 forks source link

Consider switching to flutter_timezone #495

Open tjarvstrand opened 11 months ago

tjarvstrand commented 11 months ago

flutter_native_timezone has been abandoned for more than 2 years.

I've created a fork, flutter_timezone that you might consider switching to instead as some users are starting to go get build issues with the old dependency.

techwn commented 11 months ago

@tjarvstrand , I checked the latest code, the deps has been deleted. I think we need it published to pub.dev with a patch fix like 4.3.2?

tjarvstrand commented 11 months ago

That sounds reasonable to me but I don't personally have a horse in this race. Maybe @davehorner has an opinion?

davehorner commented 11 months ago

I have no opinion of matter. I took on the dependency and it broke my build. Just trying to help with a patch for updates - as they can build with minor tweaks. If the forked dep should be used cool, removing it is fine too just wonder what we lost in taking it out.

It would be nice to update https://github.com/builttoroam/device_calendar to indicate not using or using whichever dependency is decided.

ihadabs commented 10 months ago

Any update?

IVLIVS-III commented 10 months ago

Sadly all current and past maintainers have next to no time left. Tbh most of us became maintainers to fix a bug.

To get this issue fixed as soon as possible, it would be best if someone provides a pull request that is ready to be merged.

tjarvstrand commented 10 months ago

No changes are needed, only a release to get the changes out that are already in develop

behnamsattar commented 10 months ago

The example project is still relying on flutter_native_timezone and it's included in the dependencies as a result.

tjarvstrand commented 10 months ago

The example project is still relying on flutter_native_timezone and it's included in the dependencies as a result.

No, that shouldn't affect the dependencies of the released package.

The last release was 4.3.1, made 5 months ago, apparently from master. There seems to have been some cherry-picking going on from develop to master but notably, this commit does not seem to have been included, which is why 4.3.1 still has the flutter_native_timezone dependency.

MichaelTamm commented 10 months ago

As a workaround you can use the following snippet in your pubspec.yaml:

dependencies:
  ...
  device_calendar:
    git:
      url: https://github.com/builttoroam/device_calendar.git
      ref: 4.3.1
  ...

The Git commit with the tag 4.3.1 does NOT have a dependency to flutter_native_timezone in contrast to the version 4.3.1 published on pub.dev

tjarvstrand commented 10 months ago

As a workaround you can use the following snippet in your pubspec.yaml

That's great. I think there's a risk however, of other people hitting the same issue and the probability that they will stumble upon this thread isn't super high. It could be worth making a bump to 4.3.2 (or even 4.3.1+1 with what's actually in the tagged commit) to avoid that scenario.

Just my 2 cents though, as I'm not really affected by this :)