search

builttoroam / device_calendar

A cross platform plugin for modifying calendars on the user's device
https://pub.dev/packages/device_calendar
BSD 3-Clause "New" or "Revised" License
259 stars 258 forks source link

Cherry pick request FullAccess on iOS17+ (#497) #519

Closed LeonardoCaracho closed 4 months ago

LeonardoCaracho commented 6 months ago

Cherry-pick referencing this issue.

LuizFritsch commented 6 months ago

Hello, I'm looking forward to having this PR merged and the plugin working :) Do you know by any chance when you will be able to review this PR @thomassth?

istornz commented 4 months ago

Any news about merging this mandatory fix for iOS 17+? Thanks :)

IVLIVS-III commented 4 months ago

@LeonardoCaracho thanks for creating this PR. Sorry for not looking at this sooner. Please also change the version in pubspec.yaml and add a new entry in the CHANGELOG.md. Then I can merge this PR to get the fix published. Without the version change, we cannot publish to pub.dev.

LeonardoCaracho commented 4 months ago

@LeonardoCaracho thanks for creating this PR. Sorry for not looking at this sooner. Please also change the version in pubspec.yaml and add a new entry in the CHANGELOG.md. Then I can merge this PR to get the fix published. Without the version change, we cannot publish to pub.dev.

Done! thanks for the reply ;)

istornz commented 4 months ago

@LeonardoCaracho I think you will need to change file device_calendar/example/lib/presentation/pages/calendar_event.dart line 867. This is why the CI failed.

Change with:

style: ElevatedButton.styleFrom(
  foregroundColor: Colors.white,
  backgroundColor: Colors.red),
)
IVLIVS-III commented 4 months ago
Bildschirmfoto 2024-02-28 um 17 51 09

I'm afraid, my write access is not sufficient to merge this PR… the master branch has some extra protection. We will need @thomassth to do the merge.

thomassth commented 4 months ago

Release pipeline doesn't work (again)

While I got the permission to renew the pub key, GitHub cred access is still locked from me

Paging @nickrandolph

istornz commented 4 months ago

Thanks guys for your speed!

fourthperson commented 3 months ago

Hello guys, @thomassth and @IVLIVS-III , you forgot to add the new recommended namespace value in the android block to support Gradle 8.0 and consequently, newer android versions.

https://developer.android.com/build/configure-app-module#set-namespace

it is supposed to go into the 

android {
namespace: 'your-namespace-here'
}

block of your module/build.gradle file.

Update: I can see it in your build.gradle file, on the master branch, but when I pull mine from git, I seem not to have it declared.

Here is my pubspec.yaml section of device_calendar.

device_calendar: #^4.3.2
    git:
      url: https://github.com/builttoroam/device_calendar.git
      ref: master

Is there anything I am doing wrong? Kindly assist