bukosabino / ta

Technical Analysis Library using Pandas and Numpy
https://technical-analysis-library-in-python.readthedocs.io/en/latest/
MIT License
4.26k stars 875 forks source link

How to get ADX for 13,8 #145

Open srinivasaai opened 4 years ago

srinivasaai commented 4 years ago

hi , pl guide me how to get ADX smoothing period 8 and DMI lookback period 13, i tried to do it by inserting new variable m=8 and change n =13 in the trend.py code but i couldnt get the correct results when i compare it with chart on tradingview with adx(13,8) setting.thanks

bukosabino commented 4 years ago

Can you provide me some example data (input data, output data, and output expected data)?

Best, Dario

srinivasaai commented 4 years ago

hi Dario,

i am attaching two excel sheets one with ADX setting 14,14 and another with 13,8 setting i need trend.adx to produce output for 13,8

both output of excel files cs-adx(14,14) and cs-adx(13,8) tally with tradingview charting platform ta module output for standard setting (14,14) also tally with tradingview charting platform i am unable to calculate for (13,8) setting using ta module.

regards Sri

On Tue, Apr 21, 2020 at 2:05 AM Darío López Padial notifications@github.com wrote:

Can you provide me some example data (input data, output data, and output expected data)?

Best, Dario

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/bukosabino/ta/issues/145#issuecomment-616794190, or unsubscribe https://github.com/notifications/unsubscribe-auth/APDBVLYC447JNIOXI3UN3ADRNSWZTANCNFSM4MMV5FCA .

--

bukosabino commented 4 years ago

Hi @srinivasaai,

I think you missed the excel files.

Best, Dario

srinivasaai commented 4 years ago

hi

Pls find the attached excel files

rgds sri

On Tue, Apr 21, 2020 at 6:35 PM Darío López Padial notifications@github.com wrote:

Hi @srinivasaai https://github.com/srinivasaai,

I think you missed the excel files.

Best, Dario

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/bukosabino/ta/issues/145#issuecomment-617166334, or unsubscribe https://github.com/notifications/unsubscribe-auth/APDBVLZGHVOULN2H7ILDJVLRNWKZBANCNFSM4MMV5FCA .

srinivasaai commented 4 years ago

Data.xlsx cs-adx 13,8.xlsx cs-adx 14,14.xlsx adx - expected output from ta module.xlsx

akw123 commented 4 years ago

Hi @bukosabino ,

Appreciate the work here.

I too noticed ADX calc is incorrect. In my case, ADX value appears constant throughout my dataset.

image