search

bukosabino / ta

Technical Analysis Library using Pandas and Numpy
https://technical-analysis-library-in-python.readthedocs.io/en/latest/
MIT License
4.34k stars 917 forks source link

Parabolic Sar - feature-request #51

Closed TravelTrader closed 4 years ago

TravelTrader commented 5 years ago

First: GREAT LIBRARY!!, @bukosabino! (better than all the others!!)

And because of that I would be happy to find the parabolic sar from you in it. It's very complicated. I will try to code it for myself. If I'm ready with a good solution I will send it to you. But maybe you're faster! ;)

bukosabino commented 5 years ago

Hi @TravelTrader ,

At this moment, I don't have any time to implement new features. But, you are invited to add your implementation to this library.

Best, Dario

TravelTrader commented 4 years ago

Does anybody know how to code an exact parabolic SAR? Because I found examples leading to wrong results...

bukosabino commented 4 years ago

Hi @TravelTrader ,

When I have time, I will try to implement the indicator based on this explication: https://school.stockcharts.com/doku.php?id=technical_indicators:parabolic_sar

Best, Dario

TravelTrader commented 4 years ago

Thanks @bukosabino!

The reason I am asking the second time is that you're library is the best I found. Your ATR for example is the most exact version I ever found. And for Parabolic SAR I tried all examples and libraries I found online over the last 7 months and in addition to that I tried to code it for myself. But: All examples were totally different from the Parabolic SAR of TOS, Yahoo Finance, IB, TradingView, ...

So, I am sure, your version would be the first function I can use for calculations, backtests and charting with Python! I would be very happy!! :smiley:

mprivat commented 4 years ago

@bukosabino, I just opened a pull request for you for parabolic SAR

bukosabino commented 4 years ago

Hi all,

@mprivat has pushed a PSAR implementation which was added to the library in the last version (v0.5.9). To install the last ta version:

pip install -U ta

Thank you so much @mprivat