bukzor / RefactorLib

A library for refactorization. (cheetah and python, currently)
5 stars 2 forks source link

Support yelp-cheetah 0.16.x #32

Closed asottile closed 8 years ago

asottile commented 8 years ago

I need to make a release so the test'll pass on travis, but they pass locally with current master:

$ coverage erase && coverage run -m pytest tests &&  coverage report --show-missing --skip-covered --omit=venv*
============================================================================================ test session starts ============================================================================================
platform linux2 -- Python 2.7.6, pytest-2.9.2, py-1.4.31, pluggy-0.3.1
rootdir: /home/asottile/workspace/refactorlib, inifile: 
collected 118 items 

tests/cheetah/add_comment_test.py .
tests/cheetah/directive_test.py .........
tests/cheetah/is_in_context_test.py ..
tests/cheetah/multiline_test.py ..
tests/cheetah/parse_test.py ....................................
tests/cheetah/remove_call_test.py .....
tests/cheetah/remove_decorator_test.py ........
tests/javascript/parse_test.py ...........................
tests/python/parse_test.py ............................

======================================================================================== 118 passed in 4.18 seconds =========================================================================================
Name                                      Stmts   Miss Branch BrPart  Cover   Missing
-------------------------------------------------------------------------------------
refactorlib/__init__.py                       9      1      2      1    82%   7, 5->7
refactorlib/cheetah/node.py                 170     21     40      3    89%   79-80, 103, 115-132, 142, 216-217, 12->14, 99->103, 104->98
refactorlib/cheetah/parse.py                146     11     60      5    91%   141-144, 170-172, 222, 228, 230, 232, 72->76, 162->170, 227->228, 229->230, 231->232
refactorlib/cli/xmlfrom.py                   12      3      0      0    75%   19, 24-25
refactorlib/cli/xmlstrip.py                  11      3      0      0    73%   18, 23-24
refactorlib/dictnode.py                      25      1      6      0    97%   8
refactorlib/filetypes.py                     42      7     14      3    82%   8, 47, 53, 56-59, 7->8, 46->47, 49->53
refactorlib/javascript/parse.py              60      4     24      4    90%   30, 79, 86, 93, 29->30, 76->79, 85->86, 89->93
refactorlib/node.py                          49      7     10      3    83%   39, 52-55, 72, 84, 25->27, 30->32, 66->72
refactorlib/parse.py                         32      0     10      1    98%   12->15
refactorlib/python/parse.py                  62      0     18      1    99%   97->102
refactorlib/util.py                          24      3      6      2    83%   20, 48-49, 17->20, 47->48
testing/util.py                              76     13     26      5    82%   30, 33, 41, 82-87, 101-104, 118, 28->30, 31->33, 40->41, 100->101, 117->118
-------------------------------------------------------------------------------------
TOTAL                                       926     74    248     28    91%

22 files skipped due to complete coverage.
bukzor commented 8 years ago

nits.

shipit.

coveralls commented 8 years ago

Coverage Status

Coverage increased (+0.9%) to 92.449% when pulling db95cbfa476b59be1d16d1d43ea96d3aa1b6879f on yelp_cheetah_16_x into f14cd3aa6ed6b17ddd455a3c8fbd6152cb5d4862 on master.