search

bulenkov / Darcula

Darcula Look and Feel
Apache License 2.0
723 stars 114 forks source link

Should fix launching problems on certain Linux systems #47

Closed CL-Jeremy closed 5 years ago

CL-Jeremy commented 6 years ago

29. Also #32. Tested on Debian Stretch 9.4 amd64 with OpenJDK 8u171-b11-1~deb9u1.

tulipszs commented 5 years ago

@bulenkov will this be merged to fix the Linux specific issue?

CL-Jeremy commented 5 years ago

@tulipszs Sorry, this is not ready. My commit effectively made the icon loading part stop working, as I just found out recently. Closing for now...

CL-Jeremy commented 5 years ago

@tulipszs So I actually employed the workaround discussed in #29 (https://github.com/CL-Jeremy/Darcula/commit/716af7e1606802e324b0729106200af435d92896) but I don't believe that should be merged without further investigation (especially when my result on Mac after removing the Mac-specific return statement yielded normal values, maybe related to https://github.com/JetBrains/intellij-community/commit/d1f28d8ac3a4c8e25e124778405262ede0a63d3e#diff-5f3058bc4bcd918fddec7e63aef781ad?)