search

bulenkov / Darcula

Darcula Look and Feel
Apache License 2.0
723 stars 114 forks source link

Please clarify license: add copyright notice and include it to the release jar file #53

Closed vlsi closed 5 years ago

vlsi commented 5 years ago

Hi, Darcula is nice, and Apache 2.0 is a great license choice, however would you please apply the license consistently to the project?

1) Apache 2.0 license requires re-distributions to keep copyright notice (which is fine), however your distribution of darcula.jar has NO copyright notice :(

Would you please add `NOTICE` file as `META-INF/NOTICE` to the published jar file?

Note: `NOTICE` is a small file that describes the origin (copyright owner, etc). Here's an example: http://www.apache.org/legal/src-headers.html#notice

2) Current LICENSE.txt contains an appendix which has nothing to do with a license, thus it should probably be removed: https://github.com/bulenkov/Darcula/blob/49774425c392c36d926b8a4518a3616a8cf735e2/LICENSE.txt#L178-L201

An interesting bit is `Copyright {yyyy} {name of copyright owner}` (technically speaking the appendix could be just removed from license.txt file)
vlsi commented 5 years ago

You might consider this to be not an issue. NOTICE is optional, and you do bundle META-INF/LICENSE.