buliugu / airhead-research

Automatically exported from code.google.com/p/airhead-research
0 stars 0 forks source link

Current LSA defaults to writing the term-doc matrix in matlab format even when SVDLIBJ is used #94

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Run LSA on a system without svdlibc

What is the expected output? What do you see instead?

Without svdlibc installed, Matrices.getMatrixBuilderForSVD() returns a 
MatlabSparseMatrixBuilder, which is an inefficient format if the process is 
going to be using SVDLIBJ.  There's no technical problem with the code, but it 
results in an unnecessary format conversion in SVD.java, and it's slower to 
write.  Perhaps we should revisit the getMatrixBuilder() call in light of when 
svdlibc isn't installed.  (The main issue would be when the file actually does 
need to be in matlab format, as we would need to somehow select the right 
builder.)

This issue is just so we can officially track it.

Original issue reported on code.google.com by David.Ju...@gmail.com on 8 Apr 2011 at 11:17

GoogleCodeExporter commented 9 years ago
I made a branch on github to try and refactor the SVD code into interfaces and 
implementing classes, mostly so that I could swap implementations of NMF in 
place of SVD easily.  And looking at my refactoring, it looks like this issue 
will be fixed whenever we get to that code review.

Original comment by FozzietheBeat@gmail.com on 20 Sep 2011 at 5:47