search

bulldog5046 / ha_nespresso_integration

19 stars 4 forks source link

Feature Request: Option to change water hardness #8

Open saya6k opened 9 months ago

saya6k commented 9 months ago

Home Assistant: 2023.12.1 connected trhough Bluetooth Proxy Nespresso4bda8ea

I updated to latest commit and it works great.

I think having water hardness as input_select entity or seperate service to set water hardness is needed.

Maybe having other status entities like awake, capsule_mechanism_jammed as binary_sensor so that it can represent status better.

bulldog5046 commented 9 months ago

Water Hardness: Sure, shouldn't be a problem to add in.

Sensors: I'm half way through rewriting all the decoders and including additional information i've been able to uncover. My intention is to completely overhall the sensors presented in HA as currently many of them don't represent useful information.

saya6k commented 9 months ago

Great. I'll wait for it. since git doesn't follow hacs structure, I'm not able to get update information and didn't know update happened until today. I think using beta branch would good for testers.

bulldog5046 commented 9 months ago

HACS - Yes, I will restructure the repo for it probably on the next release as things seem to be working quite well now.

As you brought it up, i'd welcome some feedback on the sensors. Here's where i am with the current dev version. I noticed i'm missing the tray sensor but anything else you thing is worth having?

Screenshot 2023-12-09 195634

saya6k commented 9 months ago

My first idea was just to use binary_sensor like binary_sensor.water_is_empty, and get true/false. But your's look great too.

bulldog5046 commented 9 months ago

Repo has been updated for the new sensor style and HACS. Heads up though, you will end up with the old sensor entities that need to be deleted after you update to this version. possibly need to update the linked entity for any front end things you've configured too. But other than that it's looking good my end.

Water hardness setting is pending. I've added it to the backend but i want to find a nicer way to present it in HA.

saya6k commented 9 months ago

OK, check. I succeed to install new version and it works fine. Though Device name is set to 'Water Hardness' and 'Water Hardness' sensor friendly_name is set to 'Expert'

saya6k commented 9 months ago

Can we have time interval setting? I think current interval is bit long.

bulldog5046 commented 9 months ago

OK, check. I succeed to install new version and it works fine. Though Device name is set to 'Water Hardness' and 'Water Hardness' sensor friendly_name is set to 'Expert'

Haha, Ok i missed that. Mines the same so will look into it.

Update interval could be adjusted, but if you're asking in relation to the device state then there is a better way to do it I just need to figure out the logic with home assistant to bring it to the frontend.

saya6k commented 9 months ago

OK, then I'll wait for water hardness change in this issue. I think select.nespresso_expert_water_hardness seems great for water hardness options if you figure out how.