search

bulldogcreative / tinypng

TinyPNG ExpressionEngine Add-on
MIT License
4 stars 1 forks source link

is tinypng-plugin also able to compress modifications? #2

Open ballmannweber opened 5 years ago

ballmannweber commented 5 years ago

two questions about your tinypng-plugin:

  1. I noticed that the plugin isn’t able to use the {base_url} variable within the image dir upload path.

  2. is tinypng-plugin also able to compress modifications within ee? I was only able to compress the original image’s size.

thank you very much, kind regards, matthias

levidurfee commented 5 years ago

Hello, I believe both of these items should work, but I'll have to do some digging. What versions of EE and TinyPNG are you using?

ballmannweber commented 5 years ago

hey there, thanks for the quick reply! I use the latest ee 5.2.4 and tinypng 3.0.0.

levidurfee commented 5 years ago

1. {base_url}

Could you show me your template and how you're trying to use {base_url}? Looking at the docs for URL and Path Settings {base_url} returns https://example.com. Your file field should return the full URL for the image, and you shouldn't need to use {base_url}, unless I'm missing something.

2. Manipulations

If you create the image manipulation after you've uploaded an image, you have to go back and sync that upload directory and apply that manipulation.

image

Either way, you should try sync'ing the images to see what happens.

ballmannweber commented 5 years ago

about 2. manipulations:

I‘ve already tried to sync because uploading images only created one new tinypng-img and not for all the manipulations (which I can see on the tinypng-website where all the conversions are counted).

levidurfee commented 5 years ago

What is the environment like? Linux/Windows? Apache/nginx? Shared hosting?

ballmannweber commented 5 years ago

it’s virtual server, linux running apache and PHP Version 7.1.9.

ballmannweber commented 5 years ago

If it helps you find the bug, can I give you access to our backend or FTP?!

levidurfee commented 5 years ago

The plugin needs an update so it can parse global path/URL variables.