search

bullet-train-co / bullet_train-base

MIT License
10 stars 16 forks source link

CableReady enable_updates is deprecated #151

Closed goulvench closed 1 year ago

goulvench commented 1 year ago

When running a freshly checked-out Bullet-Train, CableReady issues several deprecation warnings:

DEPRECATED: please use `enable_cable_ready_updates` instead. The `enable_updates` class method will be removed from a future version of CableReady 5

This method is included in the base record class, and in other contexts.

Here's CableReady's documentation for enable_updates.

I'm not yet familiar enough with Bullet-Train's codebase to take on a PR touching so many files.

gazayas commented 1 year ago

Hey @goulvench, we have an issue open here: https://github.com/bullet-train-co/bullet_train-core/issues/127

bullet_train-base has been moved to bullet_train-core/bullet_train, so for any Bullet Train internals feel free to check out bullet_train-core as a whole.

But yes, we updated to Cable Ready 5.0 recently so we'll need to update those methods.

gazayas commented 1 year ago

https://github.com/bullet-train-co/bullet_train-core/pull/305