search

bullet-train-co / bullet_train

The Open Source Ruby on Rails SaaS Template
MIT License
1.68k stars 269 forks source link

"Deploy to Heroku" button doesn't work from created repo #1609

Closed andrewculver closed 3 weeks ago

andrewculver commented 4 months ago
image
jagthedrummer commented 4 months ago

Maybe we just remove the "Deploy to Heroku" button for a configured repo? Or somehow check to see if the repo is public before asking if they want the button?

gazayas commented 4 months ago

Maybe we just remove the "Deploy to Heroku" button for a configured repo?

I actually like this idea. The original README serves as a primer for getting started with Bullet Train, so it makes sense to me that developers would look at the README and apply any additional configuration (like these deploy buttons) if it's necessary for their use-case, even after the initial setup. We don't necessarily need to have the buttons exist in a new application, as long as we point developers in the right direction.

It may be beneficial to just have solid documentation on how to deploy with each service and link to it in the README too. That would also help to cut down on things to do in bin/configure which would make it quicker/smoother for developers to get setup with a new application.

If we do want the buttons though, I submitted #1614 so developers don't have to write in their repository link.

jagthedrummer commented 3 weeks ago

@andrewculver this should be working now. (Assuming you have your Heroku account connected to your GitHub account.)