search

bullet-train-co / nice_partials

A little bit of magic to make partials perfect for components.
MIT License
276 stars 16 forks source link

HAML support? #99

Open fauno opened 4 months ago

fauno commented 4 months ago

Hi! I'm not able to render nice_partial with haml, I get a NicePartials::Partial::Section::RequiredError for this:

= render 'partial' do |partial|
  - partial.body do
    = 'hello'
= partial.body.required

From this I understand only ERB is supported? https://github.com/bullet-train-co/nice_partials/pull/45/files#r930773836

kaspth commented 4 months ago

Hey! Yeah, I'd like to support HAML as well. If you bundle open nice_partials and replace the regex you linked to with /\byield[\(? ]+(%>|\n|[^:])/ will it then work? Basically injecting \n as the terminator in there.

You should also be able to get NicePartials working for now with a manual yield:

= yield
= partial.body.required

You'd then need that in every partial (which is not ideal, hence why we have the automatic version).

fauno commented 4 months ago

I'll try and let you know! One thing I noticed is that even if I don't use other nice_partials features, I still benefit from the implicit yield :D