bullet-train-pro / bullet_train-action_models

Other
4 stars 1 forks source link

Scaffold targets-many show action attribute correctly #15

Closed gazayas closed 11 months ago

gazayas commented 1 year ago

This line in the show action was giving us an error:

<%= render 'shared/attributes/belongs_to', attribute: :approved_by %>

Action Models Error

It looks like there's more work to do here (the show page shows 0 Foos after running the action, and trying to run the action on all the records at once raises an error), I'm just not sure how to approach some of these issues, so I'd be glad to work on it if there is an explicit goal for fixing the errors.

image

I'll focus on other repositories in the meantime!

gazayas commented 1 year ago

I found another small issue which won't load the main model's index page (in the example here, Foo) unless we include the locale I added in the last commit.

jagthedrummer commented 1 year ago

@gazayas You mentioned above that there's still some work to do here. Is that still the case?

gazayas commented 12 months ago

@jagthedrummer This one's ready too.

If you need to check, you can use the targets-many example in the Starter Repository Action Models system test setup script:

https://github.com/bullet-train-co/bullet_train/blob/b0e345a0ea5b599fe0ec5fcbc3b269648428a015/test/bin/setup-action-models-system-test#L10-L23

Then after performing the action, you can click Details in the bottom right which was yielding the original error above).

スクリーンショット 2023-09-22 20 20 36
gazayas commented 11 months ago

Closing in favor of #86.