bullet-train-pro / bullet_train-action_models

Other
5 stars 1 forks source link

Use new `option` partial for check boxes #51

Closed gazayas closed 1 year ago

gazayas commented 1 year ago

Closes #47.

Depends on the following PR since I implemented the option partial:

The Action Model system tests are passing locally for me, so we should be good to go.

TODO

I technically haven't added the following styles that I deleted at the end of the class (after "rounded") in the two partials in this PR:

  1. -mt-0.5
  2. -mt-1
gazayas commented 1 year ago

Okay, I've added the styles back, I'm going to leave this one and https://github.com/bullet-train-co/bullet_train-core/pull/148 for the time being. The dark styles are working, but just in case I'll see if I can post a couple of videos here soon.

gazayas commented 1 year ago

https://user-images.githubusercontent.com/10546292/224021720-9cb08407-1026-4f2c-b886-da1241506a07.mov

jagthedrummer commented 1 year ago

@gazayas Can you look into the failing tests here if we still need this PR?

gazayas commented 1 year ago

@jagthedrummer I think the tests were just broken before in general, this one's good now!