search

bullet-train-pro / bullet_train-action_models

Other
5 stars 1 forks source link

Ensure `has_one` association is removed properly #54

Closed gazayas closed 1 year ago

gazayas commented 1 year ago

Joint PR:

All the details for why this fix works is in the joint PR.

Scaffolding::FileTransformer#replace_line_in_file

I wanted to use this method instead because it handles more general replacement, but we need to transform the file name. We could technically transform the file name first and then pass it to Scaffolding::FileTransformer#replace_line_in_file if that makes more sense, but I've at least written things this way to get things working for the time being.

jagthedrummer commented 1 year ago

@gazayas Do we still need this? If so, can you see about getting the tests passing on this branch?

gazayas commented 1 year ago

@jagthedrummer Before moving forward with this one, I think we should prioritize the following two to make sure our tests are okay:

This PR should be ok to merge, I just want to stay on the safe side and ensure the tests are working properly first.

Also as a side note, this one seems related to the following PR which was merged recently, so just making a note for myself to double check after the two PRs above are merged:

gazayas commented 1 year ago

@jagthedrummer Just checked system tests on the starter repository, this one's good to go 👍