Fixes for TargetsMany and PerformsExport

bullet-train-pro / bullet_train-action_models

Other

5 stars 1 forks source link

Fixes for TargetsMany and PerformsExport #56

Closed petekeen-cf closed 1 year ago

petekeen-cf commented 1 year ago

Fix remaining_targets query. When last_completed_id is nil the query returns nothing instead of everything.
Always call before_each in PerformsExport#before_page to set up @tempfile and @csv

andrewculver commented 1 year ago

Going to skip this PR since the issue it was designed to fix should literally never happen except for developer error and won't ever happen again in the future because the migrations are automatically generated going forward. Don't want to have code around for an edge-case that shouldn't exist. Put another way, if someone doesn't add last_completed_id with a default value, it should break, as it did on me in this case.