Prevent health check loop when action fails

bullet-train-pro / bullet_train-action_models

Other

4 stars 1 forks source link

Prevent health check loop when action fails #74

Closed scottharvey closed 9 months ago

scottharvey commented 1 year ago

I'm just opening this PR for discussion at this stage.

This PR aims to fix an issue which is caused by the Actions::BackgroundActionHealthCheckWorker when it continually keeps running an action which is never going to pass due to an exception being raise.

The idea here is to record when an exception happens and then don't re-run an action which has raised an exception in a previous run

jagthedrummer commented 1 year ago

@scottharvey @phillipn I'm curious about the state of this PR. Is it something that we need to get cleaned up and merged, or should we close it?

phillipn commented 9 months ago

Hey @jagthedrummer, this should have been closed out a while ago.

We simply removed the HealthCheckWorker in https://github.com/clickfunnels2/admin/pull/17920/files.