Closed JohnWilliston closed 9 months ago
I wouldn't say I deliberately exclude Windows, I just have never tried it and have never had anybody else report an issue here. I have made a trivial change which may fix this. Can you please try the master branch?
I downloaded the new code from GitHub and ran it with a simple "python edir.py" and got the following instead:
Traceback (most recent call last): File "
", line 189, in _run_module_as_main File " ", line 112, in _get_module_details File "C:\Users\John\VidirTest\edir.py", line 22, in from platformdirs import user_config_path ModuleNotFoundError: No module named 'platformdirs'
It clearly changes the errors. Is that helpful?
That module not found error is completely unrelated. How are you installing edir on your windows machine?
Well, when I first tried to use it, I let pipx install it via the following command:
pipx install edir
That was what I was using when I first reported the issue. When you told me you had updated your code, I assumed you wanted me to download the latest and greatest from GiHub. As such, I downloaded the edir.py file to my local directory and invoked it using the aforementioned "python edir.py" command. For the record, I have Python 3.12.0 installed.
If that's not what you intended for me to do, please clarify what you meant when you said "Can you please try the master branch?" Thanks!
Sorry, I assumed you knew how to do that. Type:
pipx install -f git+https://github.com/bulletmark/edir
Aha, that solved the issue! For what it's worth, I did know I could do a pipx install from GitHub like that, but I didn't realize that's what you were expecting. I thought I could just run the script as I've run so many other Python scripts. I guess not. Not sure why. But then I'm not an expert on either Python or pipx.
So I can close this bug?
Please do and thanks for your help! I now have edir working on Linux, macOS, and Windows. Yay!
Actually, I am not sure it fully works correctly on Windows as it assumes '/' in file paths in some areas of the code so will leave this bug open. I haven't used Windows for 28+ years but will download it to Virtualbox and try it out.
Oh, ok. I'll post other issues here if I find any. So far I've only tested deleting files and folders, which works great.
OK, have fixed those issues and released new version 2.26.
You should switch back to the PyPi version, i.e. pipx install -f edir
(and then perhaps you also need a pipx upgrade edir
?)
Perhaps edir was never designed to work on Windows, but I've used vidir with vim successfully in many Windows command shells and thought it would be great to upgrade to edir instead when I learned of it. So I installed pipx, then used that to install edir, but when I run it I get the following error:
Any thoughts? Or is edir simply not intended for use on Windows?