search

bulletmark / libinput-gestures

Actions gestures on your touchpad using libinput
3.93k stars 241 forks source link

Suggestion: Adding multiple executions of commands #289

Open MidnightNerd opened 3 years ago

MidnightNerd commented 3 years ago

Hello, it would be great to have multiple executions of the command, depending on the travel distance of the gesture. It is very hard to change the volume of the computer in single steps.

bulletmark commented 3 years ago

I added this functionality 3 years ago but wasn't completely happy with the result so never merged it to master. The problem is that fundamental to the design of libinput-gestures is that it only actions a command at the end of a gesture. So, for example, the volume script plugin that I created would only raise the volume once you finished the swipe, whereas the user really wants to hear the volume raise as he/she executes the swipe.

BierDav commented 3 years ago

Is this topic still in development. I would really need this feature.

MidnightNerd commented 3 years ago

I created a pull request for a version with this feature. It works well for me. The timeout must be edited.

LeonEstrak commented 3 years ago

Somebody please review and merge this guy's pull request, it's a great feature if its working.

BierDav commented 3 years ago

And by the way @bulletmark I think you should propably rethink your opinion about the fundamental design of this library. It is the only good library which does a good job in my opinion but for volume control and for desktop switching and many other things it would be so much more comfortable to have this feature. Moreover Windows and MacOS have this feature also interagted and as far as I know the users love it, because if you have to swipe 100 times to get to 0% (eg.) instead of simply adjust that with a precise swipe.

road2coder commented 1 year ago

Three years passed, have this feature been implemented?

MidnightNerd commented 1 year ago

As far as i know the pull request wasn't merged- and there is no commit implementing the feature. @bulletmark i know my code has no high quality. I can rewrite the code if you would like to merge it. As i don't use this program anymore i would only rewrite the code if there is a chance that the code will be merged.