search

bullhorn / taurus

Typescript client for the Bullhorn REST API
MIT License
10 stars 6 forks source link

Fix #17 UnhandledPromiseRejectionWarning Error #18

Closed martinmicunda closed 5 years ago

martinmicunda commented 6 years ago

Hi @bvkimball,

Taurus didn't handle promise error correctly so this is a fix for issue #17 (fixed for issue 1 however not issue 2, toPromise still doesn't work). Could you review, merge and publish to npm? Thanks

martinmicunda commented 6 years ago

I have also added the option to set TTL when requesting an access token.

bvkimball commented 6 years ago

Conflicts are probably because we finally merged down RXJS6 changes to master

martinmicunda commented 6 years ago

@bvkimball I have fixed the conflict so could publish to NPM when you gonna have a chance? :) This only fix Promise error, however, it doesn't fix toPromise() issue and I think that's something to do to how Taurus wrap observable and callbacks.

martinmicunda commented 6 years ago

@bvkimball any chance you could merge this PR? Thanks

martinmicunda commented 5 years ago

@bvkimball any update on this PR? thanks

amrutha-rajiv commented 5 years ago

:tada: This PR is included in version 2.1.6 :tada:

The release is available on:

Your semantic-release bot :package::rocket: