feat(FieldType): added enum back because used in novo.

bullhorn / taurus

Typescript client for the Bullhorn REST API

MIT License

10 stars 6 forks source link

feat(FieldType): added enum back because used in novo. #57

Closed bvkimball closed 4 years ago

bvkimball commented 4 years ago

Also set type to allow string, because Novo is setting type to "picker" in some forms, not sure how this is used quite yet.

ndickerson commented 4 years ago

The use of type 'picker' is erroneous behavior - just like in unit tests where the number 0 was used - it's being removed today in the Novo MR. If we leave the "Or any string" option open, it defeats the type safety.

ndickerson commented 4 years ago

Approved - We have to address the use of string in type being used by form utils before locking down the type.

amrutha-rajiv commented 4 years ago

:tada: This PR is included in version 3.3.0 :tada:

The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket: