search

bumbeishvili / org-chart

Highly customizable org chart. Integrations available for Angular, React, Vue
https://stackblitz.com/edit/web-platform-o5t1ha
MIT License
927 stars 330 forks source link

Paging is not fully integrated. #428

Open Exscotticus opened 3 months ago

Exscotticus commented 3 months ago

Basic paging (hit the button and get more results) does indeed work.

The problem is when you try to use it with pre-existing attrs.allNodes loops such as: clearHighlighting() and expandAll().

When using paging, these function should follow the paging rules in accordance with minPagingVisibleNodes and pagingStep. They should not process every single node. The entire point of paging is to prevent that.

bumbeishvili commented 3 months ago

@Exscotticus clearHighlighting sets some props on all nodes, I am not sure if it would break any functionality

image

As for the expandAll, not exactly sure how it works currently, but I would assume that it will expand all nodes including the nodes that are hidden because of paging

image

Can you provide a specific example of what is happening and what you think should happen?

A Stackblitz sample would help

Exscotticus commented 3 months ago

@bumbeishvili thanks for responding.

update(attrs.root) and updateNodesState() and render() are causing all the hidden nodes to be rendered as if there was no paging. So if the data consisted of a single root node with 5000 children but only a few showing because of paging—the UI thread freezes for many seconds as all 5000 children are rendered.

I'll see if I can create an example for you.