bumbummen99 / LaravelShoppingcart

A simple shopping cart implementation for Laravel
MIT License
501 stars 228 forks source link

Compatible with laravel 9 #157

Closed shankhadevpadam closed 2 years ago

bumbummen99 commented 2 years ago

Already done and part of #145

mrdigitalau commented 2 years ago

Hi @bumbummen99 , sorry to bug, but I can't upgrade this package with Laravel 9, my error below:

`Your requirements could not be resolved to an installable set of packages.

Problem 1

You can also try re-running composer require with an explicit version constraint, e.g. "composer require bumbummen99/shoppingcart:*" to figure out if any version is installable, or "composer require bumbummen99/shoppingcart:^2.1" if you know which you need.

Installation failed, reverting ./composer.json and ./composer.lock to their original content.`

Could something have been missed with the upgraded package?

bumbummen99 commented 2 years ago

Hi @bumbummen99 , sorry to bug, but I can't upgrade this package with Laravel 9, my error below:

`Your requirements could not be resolved to an installable set of packages.

Problem 1 - Root composer.json requires bumbummen99/shoppingcart ^4.1 -> satisfiable by bumbummen99/shoppingcart[4.1.0]. - bumbummen99/shoppingcart 4.1.0 requires illuminate/support 5.4.||5.5.||5.6.||5.7.||5.8.*||^6.0||^7.0||^8.0 -> found illuminate/support[v5.4.0, ..., 5.8.x-dev, v6.0.0, ..., 6.x-dev, v7.0.0, ..., 7.x-dev, v8.0.0, ..., 8.x-dev] but these were not loaded, likely because it conflicts with another require.

You can also try re-running composer require with an explicit version constraint, e.g. "composer require bumbummen99/shoppingcart:*" to figure out if any version is installable, or "composer require bumbummen99/shoppingcart:^2.1" if you know which you need.

Installation failed, reverting ./composer.json and ./composer.lock to their original content.`

Could something have been missed with the upgraded package?

Yeah it has not been released for L9 yet. Work has been done in the refactoring branch but it is still missing some parts and will be followed by a new major release (so far the plan). If you just need to upgrade you can also just fork it, adjust composer.json to include illuminate/* 9 too and add your repository to the vcs section of composer.json - that way it will use your fork instead while there is no release in the meantime.