bumbummen99 / LaravelShoppingcart

A simple shopping cart implementation for Laravel
MIT License
501 stars 228 forks source link

add laravel 10 support #199

Open thantzin-soe opened 1 year ago

xrezut commented 8 months ago

@bumbummen99 Hey, this PR looks good. Few months have passed, is there any plans to merge it in?

bumbummen99 commented 8 months ago

@bumbummen99 Hey, this PR looks good. Few months have passed, is there any plans to merge it in?

I am sorry to inform you that I currently do have no plans to do further contribute / maintain this project, as explained in the README of this repository.

As stated in the README, I have personally witnessed the code from this project being copied, its license modified, and it being commercialized by major companies for significant sums of money. This not only violates the copyleft provision of the MIT license but also infringes upon the intellectual property rights of all contributors to this project.

Regrettably, I lack the necessary time and financial resources to pursue legal action to enforce the project's license. I, like many others, initially contributed to this repository in need for a solution for a proprietary project i have been working on sharing my code in the process. This aligns with the essence of open-source software, which led to the project's inception as open source.

I maintain the belief that a shopping cart package, especially one intended for commercial use, can be developed by those who require such functionality, investing their own time and resources.

I have noticed that there are forks of the original project, as well as my own version, that are currently being actively maintained. Additionally, @Sartoric is a contributor on this repository too. I cannot speak on their behalf, so it is possible that they may have a different perspective on the situation and may wish to continue development - I do not know.

I hope this provides a clear explanation as to why I have not been actively engaged with this repository.

Best Regards

Sartoric commented 8 months ago

@bumbummen99

I have personally witnessed the code from this project being copied, its license modified, and it being commercialized by major companies for significant sums of money

oh wow I didn't have so much time to contribute to any project lately, but thinking of companies milking other developers "free" project ... well, it's really depressing I'm not surprised, but anyway it's sad.

I'm wondering if this could be in any way a Copilot fault.

bumbummen99 commented 8 months ago

@bumbummen99

I have personally witnessed the code from this project being copied, its license modified, and it being commercialized by major companies for significant sums of money

oh wow I didn't have so much time to contribute to any project lately, but thinking of companies milking other developers "free" project ... well, it's really depressing I'm not surprised, but anyway it's sad.

I'm wondering if this could be in any way a Copilot fault.

No, a developer confessed this to me personally, face to face. After that, I started to scan the source code, and I found quite a lot of packages they simply copied and replaced the licenses. For this package specifically, they didn't even bother to remove the DocBlock and the typos in them.

Personally, I would not be offended by Copilot suggesting code parts I provided as open source because it's just a "memory" used in part of a larger logic. For me, the issue starts when you fork the repository outright, replace the license, and don't contribute back - that goes against the essence of open source.

I've always felt that the MIT license is the perfect choice for sharing code without restricting its use in a proprietary solution. It permits including this solution in a product, and by just installing it through Composer, you are not bound to its license, so you can use any license you want for your project. It's the perfect license if everyone involved would play fair, but sadly, that's not the reality.

solstyc commented 4 months ago

I'm trying to upgrade to Laravel 10 but composer won't update because of this package. Any suggestions? Thanks