search

bumi / lnme

Your friendly Bitcoin Lightning ⚡ payment page ⚡
MIT License
167 stars 30 forks source link

Add Tor support for Heroku #18

Closed crc32 closed 3 years ago

crc32 commented 3 years ago

I added the Tor buildpack to the app.json so that the Heroku install could include tor support. After I was able to figure out how to incorporate the TLS certificate as HEX, it worked flawlessly.

bumi commented 3 years ago

That's great. I was a bit hesitant to use non official buildpacks. Maybe you could add a note in the readme that that buildpack is used and a link to it? Then people know it and can review it.

crc32 commented 3 years ago

Awesome, I added that statement to the README.md, along with instructions for disabling the buildpack. I also added a quick pointer to the proper procedure for using Heroku on one's own domain. While the second piece isn't strictly necessary, I think it would be useful for people not totally up on Heroku (I wasn't myself). The awesome piece of this is that, even with the Tor buildpack, this all fits within the free tier on Heroku, so I think it could see good use that way.

bumi commented 3 years ago

thanks a lot! very helpful indeed. That's great for everybody who uses raspiblitz, umbrel, etc.