search

bummzack / page-blocks

Page Blocks Module for SilverStripe
BSD 3-Clause "New" or "Revised" License
15 stars 12 forks source link

FIX: CMS fields issue #16

Open a2nt opened 7 years ago

a2nt commented 7 years ago

This function won't work in case CMS was modified or in case extension extends an object: $fields->addFieldsToTab('Root.Main', array( $gridField ), 'Metadata');

bummzack commented 7 years ago

The extension was specifically designed to be added to Pages, not DataObjects (I don't think the publish page & blocks action is going with DataObjects…).

If you modify the fields, make sure your code modifies the fields before the extension applies its logic. You'll only run into problems when you remove the Metadata field before the extension is applied.

a2nt commented 7 years ago

why won't work I think will work ok with versioned DataObjects?

bummzack commented 7 years ago

Have you tried it? The PublishAllExtension that is being used for the "Publish Page & Blocks" action doesn't consider versioned DataObjects at the moment.

You can easily add page-blocks to your dataobject, but you should do so manually or with another extension, not by using the PageBlocks extension. Just use the GridFieldConfig_BlockEditor config and create a GridField with it…