Open paulRbr opened 3 weeks ago
feedbacks following live test:
bump preview: all good
option -o
does not work, IMO it can be removed
bump preview: all good
bump deploy: all good in hub, when interactive mode is selected and api filename should be removed, I have an error (only when flag --auto-create was missing, maybe a false positive)
bump diff : all good
bump overlay: all good
I'm very impressed by this new version of CLI, well done 👏
in hub, when interactive mode is selected and api filename should be removed, I have an error (only when flag --auto-create was missing, maybe a false positive)
As discussed in sync, there was a bug when selecting multiple times the same file: I've fixed the code to only present files that have not yet been selected (and thus the error should not be possible anymore)
- node v20 is required as minimal version
Changed the minimal version in the package.json :white_check_mark:
@Polo2 could you take a second look and if happy approve the PR :pray:?
This is basically a re-write from scratch using a newly generated package from Oclif v4 due to a too big of a jump from Oclif v1 to oclif v4.
I've then copied files from our CLI one by one making sure compilation (and features) work.
~There are still some work to be done:~ (all done :tada:)
Notes for the reviewer
It's a big PR, sorry for that, we can do a pair-review if you feel like it :hugs:.
Also, there are a few things I had to adapt in the CLI to make this current upgrade:
open
node package to work (it was included in oclif's fancy-ux in v1 but isn't part of oclif anymore). This lead me to comment (and thus disable the--open
flag features of the CLI)~ it works!bump preview --live
one) because the mocha test process never ends due to the command “waiting”. I tried with mocking thestdin
(as described here) but I don't think an “exit signal” character exists which I can send tostdin
to stop the running command. This lead me to comment the related test.Closes #448