bump-sh / cli

Bump.sh CLI - Deploy your OpenAPI & AsyncAPI documentations from your CI
https://bump.sh
MIT License
44 stars 4 forks source link

maintenance: upgrade to TypeScript 5, Oclif 4, node 18+ #587

Open paulRbr opened 3 weeks ago

paulRbr commented 3 weeks ago

This is basically a re-write from scratch using a newly generated package from Oclif v4 due to a too big of a jump from Oclif v1 to oclif v4.

I've then copied files from our CLI one by one making sure compilation (and features) work.

~There are still some work to be done:~ (all done :tada:)

Notes for the reviewer

It's a big PR, sorry for that, we can do a pair-review if you feel like it :hugs:.

Also, there are a few things I had to adapt in the CLI to make this current upgrade:

Closes #448

Polo2 commented 1 week ago

feedbacks following live test:

bump preview: all good option -o does not work, IMO it can be removed

bump preview: all good

bump deploy: all good in hub, when interactive mode is selected and api filename should be removed, I have an error (only when flag --auto-create was missing, maybe a false positive)

bump diff : all good

bump overlay: all good

I'm very impressed by this new version of CLI, well done 👏

paulRbr commented 4 days ago

in hub, when interactive mode is selected and api filename should be removed, I have an error (only when flag --auto-create was missing, maybe a false positive)

As discussed in sync, there was a bug when selecting multiple times the same file: I've fixed the code to only present files that have not yet been selected (and thus the error should not be possible anymore)

  • node v20 is required as minimal version

Changed the minimal version in the package.json :white_check_mark:

paulRbr commented 4 days ago

@Polo2 could you take a second look and if happy approve the PR :pray:?