bumptech / bump-api-ios

make your app bumpable in seconds
http://bu.mp/api
Other
146 stars 52 forks source link

Explicit max packet size #14

Closed luca-bernardi closed 11 years ago

luca-bernardi commented 11 years ago

Trying to send a large file ~1Mb I got an assertion fail, specifically Assertion failed: ([data length] < MAX_BAM_PACKET_SIZE). I haven't seen anywhere documented this limit.

Since this limit exist we should aware of how much this is or have a method to check if the [NSData length] exceed this limit. I understand that you may want to keep this size hidden and / or be able to change this in the future but you can provide a method like + (BOOL)dataLengthExceedMaxPacketSize:(NSUInteger)dataLength.

tewks commented 11 years ago

Hi there; sorry about that. The max packet size is 512k.