search

bumptech / glide

An image loading and caching library for Android focused on smooth scrolling
https://bumptech.github.io/glide/
Other
34.67k stars 6.12k forks source link

Fix nullable item handling in LruCache/LruResourceCache #2740

Open sjudd opened 6 years ago

sjudd commented 6 years ago

We're inconsistently checking for null in puts/get, but not when evicting items. Either we should check for null everywhere, or not allow null values.

SUPERCILEX commented 6 years ago

@sjudd I believe this was fixed in bd2f21595d3404e6aadf1f4333bef369509c4a56. Specifically, https://github.com/bumptech/glide/commit/bd2f21595d3404e6aadf1f4333bef369509c4a56#diff-b808002580873f426e71f18af14dbddc and https://github.com/bumptech/glide/commit/bd2f21595d3404e6aadf1f4333bef369509c4a56#diff-f5ddda021c728416b658f67a954dc6c6.