TWiStErRob
commented
8 years ago Is this an IntentService? If so that's probably wrapping ApplicationContext. Which means that each load started will be attached to the app, meaning there's no automatic freeing (can't attach Glide's magic fragment).
If I'm right: you're not freeing Bitmaps, I wonder how it works for you. I think you can help Glide by explicitly letting go:
FutureTarget<Bitmap> target = Glide
.with(this)
.load(url)
.asBitmap()
.into(-1, -1)
;
try {
FileOutputStream fos = new FileOutputStream(file);
target.get().compress(...);
...
} catch (Exception e) {
Log.e("Error", "Saving to external storage failed");
} finally {
Glide.clear(target);
}There's also a lesser-known Glide API for this use case:
FutureTarget<byte[]> target = Glide
.with(this)
.load(url)
.asBitmap()
.toBytes(CompressFormat.PNG, 100) // use Glide to wrap Bitmap.compress
//.atMost().override(2000, 2000) // useful if you want to save space on device
// (max(display width/height) is a good target if you don't use a zooming ImageView)
.format(DecodeFormat.PREFER_ARGB_8888) // make sure you're not losing quality, default is 565
.diskCacheStrategy(DiskCacheStrategy.NONE) // don't populate the cache if not used
.skipMemoryCache(true) // there's no point in querying or returning loaded stuff to memory cache
.into(Target.SIZE_ORIGINAL, Target.SIZE_ORIGINAL) // -1 is not valid
;
try {
FileOutputStream fos = new FileOutputStream(file);
fos.write(target.get());
fos.flush();
fos.close();
} catch (Exception e) {
Log.e("Error", "Saving to external storage failed");
} finally {
Glide.clear(target);
}Notes:
-1is not a valid width/height, usew|h > 0orTarget.SIZE_ORIGINAL- The additional paramters to the load are useful even if you don't use
toBytes()! into's arguments are ignored if you haveoverride
I hope you can deploy the finally-clear change and see if it helps that user. Please note that if you're not using the atMost-override-like transformations you're just wasting battery using Glide. There's no point in decoding a Bitmap just to re-encode it again. Glide is an image loading library and you're using it as a simple url downloader. Consider directly using OkHttp or Volley (Glide can integrate with these too), it'll save a lot of power and be much-much faster for the users.
tom-anders
So I'm trying to download and save many (~1800) full size images as part of an IntentService. This is the code:
Now, for me this works fine, but a user sent me a log where Glide throws an OutOfMemoryException after about 800 downloaded images:
Sorry, I can't get the stack trace formatted properly for some reason
What am I doing wrong here?