search

bundesAPI / nina-api

Erhalten Sie wichtige Warnmeldungen des Bevölkerungsschutzes für Gefahrenlagen wie zum Beispiel Gefahrstoffausbreitung oder Unwetter per Programmierschnittstelle.
https://nina.api.bund.dev/
78 stars 5 forks source link

deutschland workflow is failing #24

Closed t-huyeng closed 1 year ago

t-huyeng commented 1 year ago

@wirthual do you have a chance to look at this?

looks like it is still an issue with the versions: Only one sdist may be uploaded per release.

See: https://github.com/bundesAPI/nina-api/actions/runs/4324499161

wirthual commented 1 year ago

Yes. Let me have a look. Thanks for the reminder.

t-huyeng commented 1 year ago

As we have also changed the code on the nina-api (switched AGS to ARS):

Do you think it would be possible to update the packageVersion for each release? So if someone still wants to use the AGS version it would be possible.

If I am not mistaken, the packageVersion is currently set manually in the generator_config.yaml.

wirthual commented 1 year ago

Actually thats the right way to do it, since you can not upload a package with the same version twice.

Skipping de_nina-1.0.2-py3-none-any.whl because it appears to already exist

A nice thing would be to pull the version from the git tag at some point. But for now, let me bump the version manually.

t-huyeng commented 1 year ago

True, I just remembered we already talked about this here : https://github.com/wirthual/deutschland-generator-action/issues/3

wirthual commented 1 year ago

Ah I remember.

Could you add a note in the readme why someone would need to use 1.0.2 instead of 1.1.0?

wirthual commented 1 year ago

Also it seems the upload already happened for the Merge request and not from the main branch. Something we also can improve.

https://github.com/wirthual/deutschland-generator-action/issues/5#issue-1608826039