search

bundestag / gesetze-tools

Scripts to maintain German law git repository
GNU Lesser General Public License v3.0
114 stars 21 forks source link

Restore banz scraper and lawgit functionality #24

Closed jbruechert closed 3 years ago

jbruechert commented 3 years ago

GitHub is not updating the checks status of the old pull request, so maybe this one works better.

jbruechert commented 3 years ago

Is it okay if I merge this myself to be able to work on stuff building on top of this? This code has been around for a few days, but initially in a different pull request.

ulfgebhardt commented 3 years ago

Since @darkdragon-001 does not do the review, I will approve and rely on the tests. Would you like me to disable the required review to make life easier for you? This was a messure to make merging easier when we had no tests since any person could approve your PR and work could continue while still having some sort of check

jbruechert commented 3 years ago

If there is nobody who likes to do the reviews right now, I think disabling the requirement would be good.

The tests are currently only testing the syntax and not the functionality, so reviews would generally be helpful.

ulfgebhardt commented 3 years ago

I think my capabilities in reviewing python are less then the automatic syntax check ;)

I disabled the review requirement, so you just need to pass the tests. It seems like you are the only one willing & able to contribute at the moment :(